ospfd: logging behavior for area id mismatches #16745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an ospf interface is not in the backbone area, but it receives a packet from the backbone, no logs are generated for this mismatch due to the current check. However, the opposite scenario does generate logs. Removing this check shouldn’t cause issues, because the `ospf_verify_header()` function will still drop packets with a different area id, even if the VLINK is active. Signed-off-by: Loïc Sang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ospf interface is not in the backbone area, but it receives a packet from the backbone, no logs are generated for this mismatch due to the current check. However, the opposite scenario does generate logs. Removing this check shouldn’t cause issues, because the
ospf_verify_header()function will still drop packets with a different area id, even if the VLINK is active.